THIS IS A TEST INSTANCE ONLY! REPOSITORIES CAN BE DELETED AT ANY TIME!

Browse Source

Add RuboCop to enforce some styles (#31509).

Patch by Marius BALTEANU and Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18259 e93f8b46-1217-0410-a6f0-8f06a7374b81
pull/116/head
Go MAEDA 3 months ago
parent
commit
8baddf11bc
4 changed files with 2263 additions and 0 deletions
  1. 44
    0
      .rubocop.yml
  2. 2208
    0
      .rubocop_todo.yml
  3. 2
    0
      Gemfile
  4. 9
    0
      doc/RUNNING_TESTS

+ 44
- 0
.rubocop.yml View File

@@ -0,0 +1,44 @@
inherit_from: .rubocop_todo.yml

AllCops:
TargetRubyVersion: 2.3
TargetRailsVersion: 5.2

Exclude:
- '**/vendor/**/*'
- '**/tmp/**/*'
- '**/bin/**/*'
- '**/plugins/**/*'
- '**/extra/**/*'
- '**/lib/generators/**/templates/*'
- '**/lib/tasks/**/*'
- '**/files/**/*'

# Enable extensions

Rails:
Enabled: true

# Rules for Redmine

Layout/SpaceBeforeBlockBraces:
Enabled: false

Rails/BulkChangeTable:
Exclude:
- 'db/migrate/20120714122200_add_workflows_rule_fields.rb'
- 'db/migrate/20131214094309_remove_custom_fields_min_max_length_default_values.rb'

Style/FrozenStringLiteralComment:
Enabled: true
EnforcedStyle: always
Exclude:
- 'db/**/*.rb'
- 'Gemfile'
- 'Rakefile'
- 'config.ru'
- 'config/additional_environment.rb'

Style/HashSyntax:
Enabled: true
EnforcedStyle: no_mixed_keys

+ 2208
- 0
.rubocop_todo.yml
File diff suppressed because it is too large
View File


+ 2
- 0
Gemfile View File

@@ -84,6 +84,8 @@ group :test do
gem 'puma', '~> 3.7'
gem "capybara", '~> 2.13'
gem "selenium-webdriver"
# RuboCop
gem 'rubocop', '~> 0.71.0'
end

local_gemfile = File.join(File.dirname(__FILE__), "Gemfile.local")

+ 9
- 0
doc/RUNNING_TESTS View File

@@ -71,3 +71,12 @@ https://sites.google.com/a/chromium.org/chromedriver/

Capybara tests can be run with:
`rails test:system`

Running RuboCop, a static code analyzer
=======================================

RuboCop allows you to find out if the code violates the Ruby Style Guide.
Checking with RuboCop is recommended when you write patches.

You can run RuboCop with:
`bundle exec rubocop [file ...]`

Loading…
Cancel
Save