THIS IS A TEST INSTANCE ONLY! REPOSITORIES CAN BE DELETED AT ANY TIME!

Browse Source

add chdir-notify API

If one part of the code does a permanent chdir(), then this
invalidates any relative paths that may be held by other
parts of the code. For example, setup_work_tree() moves us
to the top of the working tree, which may invalidate a
previously stored relative gitdir.

We've hacked around this case by teaching setup_work_tree()
to re-run set_git_dir() with an adjusted path, but this
stomps all over the idea of module boundaries.
setup_work_tree() shouldn't have to know all of the places
that need to be fed an adjusted path. And indeed, there's at
least one other place (the refs code) which needs adjusting.

Let's provide an API to let code that stores relative paths
"subscribe" to updates to the current working directory.
This means that callers of chdir() don't need to know about
all subscribers ahead of time; they can simply consult a
dynamically built list.

Note that our helper function to reparent relative paths
uses the simple remove_leading_path(). We could in theory
use the much smarter relative_path(), but that led to some
problems as described in 41894ae3a3 (Use simpler
relative_path when set_git_dir, 2013-10-14). Since we're
aiming to replace the setup_work_tree() code here, let's
follow its lead.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
tags/v2.18.0-rc0
Jeff King Junio C Hamano 1 year ago
parent
commit
2b5ed37365
3 changed files with 167 additions and 0 deletions
  1. 1
    0
      Makefile
  2. 93
    0
      chdir-notify.c
  3. 73
    0
      chdir-notify.h

+ 1
- 0
Makefile View File

@@ -772,6 +772,7 @@ LIB_OBJS += branch.o
LIB_OBJS += bulk-checkin.o
LIB_OBJS += bundle.o
LIB_OBJS += cache-tree.o
LIB_OBJS += chdir-notify.o
LIB_OBJS += checkout.o
LIB_OBJS += color.o
LIB_OBJS += column.o

+ 93
- 0
chdir-notify.c View File

@@ -0,0 +1,93 @@
#include "cache.h"
#include "chdir-notify.h"
#include "list.h"
#include "strbuf.h"

struct chdir_notify_entry {
const char *name;
chdir_notify_callback cb;
void *data;
struct list_head list;
};
static LIST_HEAD(chdir_notify_entries);

void chdir_notify_register(const char *name,
chdir_notify_callback cb,
void *data)
{
struct chdir_notify_entry *e = xmalloc(sizeof(*e));
e->name = name;
e->cb = cb;
e->data = data;
list_add_tail(&e->list, &chdir_notify_entries);
}

static void reparent_cb(const char *name,
const char *old_cwd,
const char *new_cwd,
void *data)
{
char **path = data;
char *tmp = *path;

if (!tmp)
return;

*path = reparent_relative_path(old_cwd, new_cwd, tmp);
free(tmp);

if (name) {
trace_printf_key(&trace_setup_key,
"setup: reparent %s to '%s'",
name, *path);
}
}

void chdir_notify_reparent(const char *name, char **path)
{
chdir_notify_register(name, reparent_cb, path);
}

int chdir_notify(const char *new_cwd)
{
struct strbuf old_cwd = STRBUF_INIT;
struct list_head *pos;

if (strbuf_getcwd(&old_cwd) < 0)
return -1;
if (chdir(new_cwd) < 0) {
int saved_errno = errno;
strbuf_release(&old_cwd);
errno = saved_errno;
return -1;
}

trace_printf_key(&trace_setup_key,
"setup: chdir from '%s' to '%s'",
old_cwd.buf, new_cwd);

list_for_each(pos, &chdir_notify_entries) {
struct chdir_notify_entry *e =
list_entry(pos, struct chdir_notify_entry, list);
e->cb(e->name, old_cwd.buf, new_cwd, e->data);
}

strbuf_release(&old_cwd);
return 0;
}

char *reparent_relative_path(const char *old_cwd,
const char *new_cwd,
const char *path)
{
char *ret, *full;

if (is_absolute_path(path))
return xstrdup(path);

full = xstrfmt("%s/%s", old_cwd, path);
ret = xstrdup(remove_leading_path(full, new_cwd));
free(full);

return ret;
}

+ 73
- 0
chdir-notify.h View File

@@ -0,0 +1,73 @@
#ifndef CHDIR_NOTIFY_H
#define CHDIR_NOTIFY_H

/*
* An API to let code "subscribe" to changes to the current working directory.
* The general idea is that some code asks to be notified when the working
* directory changes, and other code that calls chdir uses a special wrapper
* that notifies everyone.
*/

/*
* Callers who need to know about changes can do:
*
* void foo(const char *old_path, const char *new_path, void *data)
* {
* warning("switched from %s to %s!", old_path, new_path);
* }
* ...
* chdir_notify_register("description", foo, data);
*
* In practice most callers will want to move a relative path to the new root;
* they can use the reparent_relative_path() helper for that. If that's all
* you're doing, you can also use the convenience function:
*
* chdir_notify_reparent("description", &my_path);
*
* Whenever a chdir event occurs, that will update my_path (if it's relative)
* to adjust for the new cwd by freeing any existing string and allocating a
* new one.
*
* Registered functions are called in the order in which they were added. Note
* that there's currently no way to remove a function, so make sure that the
* data parameter remains valid for the rest of the program.
*
* The "name" argument is used only for printing trace output from
* $GIT_TRACE_SETUP. It may be NULL, but if non-NULL should point to
* storage which lasts as long as the registration is active.
*/
typedef void (*chdir_notify_callback)(const char *name,
const char *old_cwd,
const char *new_cwd,
void *data);
void chdir_notify_register(const char *name, chdir_notify_callback cb, void *data);
void chdir_notify_reparent(const char *name, char **path);

/*
*
* Callers that want to chdir:
*
* chdir_notify(new_path);
*
* to switch to the new path and notify any callbacks.
*
* Note that you don't need to chdir_notify() if you're just temporarily moving
* to a directory and back, as long as you don't call any subscribed code in
* between (but it should be safe to do so if you're unsure).
*/
int chdir_notify(const char *new_cwd);

/*
* Reparent a relative path from old_root to new_root. For example:
*
* reparent_relative_path("/a", "/a/b", "b/rel");
*
* would return the (newly allocated) string "rel". Note that we may return an
* absolute path in some cases (e.g., if the resulting path is not inside
* new_cwd).
*/
char *reparent_relative_path(const char *old_cwd,
const char *new_cwd,
const char *path);

#endif /* CHDIR_NOTIFY_H */

Loading…
Cancel
Save