THIS IS A TEST INSTANCE ONLY! REPOSITORIES CAN BE DELETED AT ANY TIME!

Browse Source

git-svn: trim leading and trailing whitespaces in author name

In some cases, the svn author names might contain leading or trailing
whitespaces, leading to messages such as:

  Author: user1
   not defined in authors.txt

(the trailing newline leads to the line break). The user "user1" is
defined in authors.txt though, e.g.

  user1 = User <user1@example.com>

Fix this by trimming the author name retreived from svn before using it
in check_author.

Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
tags/v2.24.0-rc0
Tobias Klauser Junio C Hamano 1 month ago
parent
commit
4ddd4bddb1
1 changed files with 4 additions and 0 deletions
  1. +4
    -0
      perl/Git/SVN.pm

+ 4
- 0
perl/Git/SVN.pm View File

@@ -1491,6 +1491,10 @@ sub call_authors_prog {

sub check_author {
my ($author) = @_;
if (defined $author) {
$author =~ s/^\s+//g;
$author =~ s/\s+$//g;
}
if (!defined $author || length $author == 0) {
$author = '(no author)';
}


Loading…
Cancel
Save